mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 52372: Reversed the order of using docker config file from URI.
Date Thu, 29 Sep 2016 01:03:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52372/#review150793
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Sept. 29, 2016, 12:41 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52372/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2016, 12:41 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch reversed the order of using the docker config file in
> docker containerizer. Now the logic is that we always look for the
> docker config file in the sandbox (which may be downloaded by
> fetcher via a specified URI). Then, if there does not exist a
> docker config file and a docker config file is specified via the
> agent flag '--docker_config'. We use that as our new HOME directory.
> 
> This should not break previous users since it is most unlikely
> any user would specifed both URI and the agent flag for a docker
> config file at the same time.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp 7c38123f1bedc7cda9c30ce9dd9877b7c41988fb 
> 
> Diff: https://reviews.apache.org/r/52372/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message