mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 52199: Fixed warning in `stout_tests`.
Date Thu, 29 Sep 2016 00:32:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52199/#review150448
-----------------------------------------------------------



I can tweak these before committing.


3rdparty/stout/tests/os/filesystem_tests.cpp (line 405)
<https://reviews.apache.org/r/52199/#comment218841>

    I'd prefer `ASSERT_TRUE(written == TRUE)`



3rdparty/stout/tests/os/filesystem_tests.cpp (line 416)
<https://reviews.apache.org/r/52199/#comment218436>

    It's a bit interesting that this one doesn't warn.  Underneath, the gtest macro is actually
evaluating:
    ```
    ASSERT_TRUE(!(written));
    ```



3rdparty/stout/tests/os/process_tests.cpp (line 231)
<https://reviews.apache.org/r/52199/#comment218842>

    Same here: `ASSERT_TRUE(written == TRUE)`


- Joseph Wu


On Sept. 22, 2016, 10:07 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52199/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2016, 10:07 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed warning in `stout_tests`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/tests/os/filesystem_tests.cpp b747c168687af48427af167941a11a45aa0cd352

>   3rdparty/stout/tests/os/process_tests.cpp 1e26877c7aee67d629789205639ad7c35df1d9c7

> 
> Diff: https://reviews.apache.org/r/52199/diff/
> 
> 
> Testing
> -------
> 
> Windows: build
> OSX: make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message