mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jacob Janco <jjanco....@gmail.com>
Subject Re: Review Request 50268: Target shutdownFramework to associated agents.
Date Wed, 28 Sep 2016 23:55:38 GMT


> On July 21, 2016, 9:14 a.m., Alexander Rukletsov wrote:
> > src/slave/slave.cpp, line 2289
> > <https://reviews.apache.org/r/50268/diff/1/?file=1448437#file1448437line2289>
> >
> >     With this patch, this should not happen very often. The only case coming to
my mind is when a framework is already removed when the shutdown messages reaches the agent.
> >     
> >     Hence I would suggest we leave a warning for now. If it stays problematic, we
can revisit.

Thanks for reviewing this Alex, stopped work on it after Ben's comments on the Jira. Closing
this up and tuning the verbosity of the log messages.


- Jacob


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50268/#review143063
-----------------------------------------------------------


On July 21, 2016, 8:39 a.m., Jacob Janco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50268/
> -----------------------------------------------------------
> 
> (Updated July 21, 2016, 8:39 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5874
>     https://issues.apache.org/jira/browse/MESOS-5874
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Target shutdownFramework to associated agents.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 78a8889313179b4509a6657e6c61d9f6d3bb99c0 
>   src/slave/slave.cpp da643e6e50b2f313705d2f862c961291aa5d2f22 
> 
> Diff: https://reviews.apache.org/r/50268/diff/
> 
> 
> Testing
> -------
> 
> 5 frameworks on 1 agent with 2 agents in cluster
> pre: ShutDownFrameworkMessage sent to both agents. 
> post: ShutdownFrameworkMessage sent to agent with executors associated with framework.
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message