mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 51560: Support health check without specifying `type`.
Date Wed, 28 Sep 2016 21:08:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51560/#review150756
-----------------------------------------------------------


Fix it, then Ship it!




LGTM. Thanks!


src/master/master.cpp (lines 4062 - 4064)
<https://reviews.apache.org/r/51560/#comment218819>

    Some minor tweaks:
    
    ```
    // TODO(haosdent): Once we have internal TaskInfo separate from the v0 TaskInfo (See MESOS-6268),
consider extracting the following adaptation code into devolve methods from v0 and v1 TaskInfo
to internal TaskInfo.
    ```



src/master/master.cpp (lines 4083 - 4085)
<https://reviews.apache.org/r/51560/#comment218822>

    ```
    // For backwards compatibility with the v0 and v1 API, when the type of the health check
    is not specified, determine its type from the `http` and `command` fields.
    ```
    
    And move it to above the TODO as a summary for the whole block.



src/master/master.cpp (line 4089)
<https://reviews.apache.org/r/51560/#comment218823>

    I guess strictly speaking, for backwards compatbility we don't need to look at tcp at
all as it didn't exist in v0 and v1 API.



src/master/master.cpp (lines 4092 - 4093)
<https://reviews.apache.org/r/51560/#comment218824>

    Aligning with the open paren would look better IMO.


- Jiang Yan Xu


On Sept. 28, 2016, 12:05 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51560/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2016, 12:05 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joseph Wu, Silas Snider, and Jiang Yan
Xu.
> 
> 
> Bugs: MESOS-6110
>     https://issues.apache.org/jira/browse/MESOS-6110
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Absence of `type` in command health check and HTTP health check are
> supported for backwards compatibility and will be deprecated in
> Mesos 2.0.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 66a672f6d16233e96b29e330a9e6c474546fa851 
> 
> Diff: https://reviews.apache.org/r/51560/diff/
> 
> 
> Testing
> -------
> 
> Test case is https://reviews.apache.org/r/52301/
> 
> ```
> W0927 22:24:06.558188 117159 master.cpp:4079] The type of health check is not set; use
of 'HealthCheck' without specifying 'type' will be deprecated in Mesos 2.0
> ...
> [       OK ] HealthCheckTest.HealthyTaskViaHTTPWithoutType (946 ms)
> [----------] 1 test from HealthCheckTest (972 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1005 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message