mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <>
Subject Re: Review Request 51879: Autodetect value of resource when not specified in static resources.
Date Wed, 28 Sep 2016 19:25:20 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 28, 2016, 7:25 p.m.)

Review request for mesos and Jiang Yan Xu.


Modified based on review comments in previous commits in this chain.

Bugs: MESOS-6062

Repository: mesos


When static resources indicate resources with a positive size, we use
that for the resources on the agent. However, --resources can include
resources with no size, which indicates that mesos agent determine the
size of those resources from the agent and uses that information. For
disk resources, this is not allowed for PATH disks since PATH disks
can be carved into smaller chunks and we cannot assume that the whole
physical disk is available to the PATH disk.

With this change, JSON or textual representation for disk resources
that specify scalar value of 0 would not result in an error, but those
resources will not be accounted for until a valid size is determined
for such resources. A scalar value of -1 in JSON or textual formats
still results in an invalid resource.

Diffs (updated)

  include/mesos/resources.hpp 3ef8cacee529addc745b4aeb6398d7606c61b749 
  include/mesos/v1/resources.hpp ef56b4960b103a3efd916fab64796aa334ba44c6 
  src/common/resources.cpp 0774ff0669e831494d5b12b88e19dfa0a4a3f757 
  src/slave/containerizer/containerizer.cpp d46882baa904fd439bffb23c324828b777228f1c 
  src/slave/containerizer/mesos/isolators/gpu/allocator.hpp b2eabfebef99ccebef427d144bb816adc0175ecf

  src/slave/containerizer/mesos/isolators/gpu/allocator.cpp c1a87e9e5c07529bc1d077f68477108a40506806

  src/v1/resources.cpp 62a644ebbd13cfc0862bd118ba16c43e0f6aaf90 



Tests passed.


Anindya Sinha

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message