-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52309/#review150735
-----------------------------------------------------------
src/slave/container_loggers/lib_logrotate.cpp (lines 235 - 237)
<https://reviews.apache.org/r/52309/#comment218792>
The `--user` should be passed into the stderr-logger binary too.
- Joseph Wu
On Sept. 27, 2016, 12:59 p.m., Sivaram Kannan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52309/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2016, 12:59 p.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-5856
> https://issues.apache.org/jira/browse/MESOS-5856
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Pass the user variable from library to binary.
>
> Note: The previous rbr request to this file commit has been discarded. Refer - https://reviews.apache.org/r/52096/
>
>
> Diffs
> -----
>
> src/slave/container_loggers/lib_logrotate.cpp 0ca2b3d7dbb57c11c0740aed3914a6b75329af99
>
> Diff: https://reviews.apache.org/r/52309/diff/
>
>
> Testing
> -------
>
> 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs
are getting rotated.
> 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting
rotated.
>
>
> Thanks,
>
> Sivaram Kannan
>
>
|