mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 52007: Added nested container helper 'parseSandboxPath()'.
Date Wed, 28 Sep 2016 16:45:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52007/#review150726
-----------------------------------------------------------




src/slave/containerizer/mesos/paths.cpp (lines 33 - 36)
<https://reviews.apache.org/r/52007/#comment218775>

    My bad that I haven't expressed myself clearly. I think the parsing of executor run directory
should still be in slave/paths.hpp|cpp.
    
    The parsing here in containerizer paths.hpp|cpp should just parse the part starting from
the executor run directory (not the entire path).
    
    In other words,
    ```
    Try<ContainerID> parseSandboxPath(const string& rootSandboxPath);
    ```


- Jie Yu


On Sept. 28, 2016, 5:49 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52007/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2016, 5:49 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph Wu, Kevin
Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-6191
>     https://issues.apache.org/jira/browse/MESOS-6191
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added nested container helper 'parseSandboxPath()'.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/paths.hpp 8d8bcb41f1e63613bc09fa06e3378ec4e930878e 
>   src/slave/containerizer/mesos/paths.cpp 7635228d59a783ece0501710ec4d1f9e67252d32 
>   src/tests/paths_tests.cpp 0671ee25b484cacf08c9a20ee6eba88e6f14fa97 
> 
> Diff: https://reviews.apache.org/r/52007/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message