mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 52010: Supported filesystem linux isolator to be nested aware.
Date Wed, 28 Sep 2016 05:52:17 GMT


> On Sept. 18, 2016, 3:33 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp, line 245
> > <https://reviews.apache.org/r/52010/diff/1/?file=1501162#file1501162line245>
> >
> >     I think we can still call parseExecutorRunPath first. Then, we can call parseContainerPath
(in containerizer paths.hpp) to get the containerId

Now we have a separate `parseSandboxPath`


> On Sept. 18, 2016, 3:33 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp, lines 293-300
> > <https://reviews.apache.org/r/52010/diff/1/?file=1501162#file1501162line293>
> >
> >     Hum, we should enforce that in containerizer, rather than doing this check everywhere.
> >     
> >     Can we make sure, in containerizer, that if a parent container is being destroyed
(state == DESTROYING), no child container can be launched?

Yes, we can guarantee that.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52010/#review149394
-----------------------------------------------------------


On Sept. 27, 2016, 10:49 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52010/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2016, 10:49 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph Wu, Kevin
Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-6191
>     https://issues.apache.org/jira/browse/MESOS-6191
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported filesystem linux isolator to be nested aware.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 0a85935550e36c9142d845465cfa70a1634a647a

>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp ea418252956c8089acc5a491888ed7f6df6cafcd

> 
> Diff: https://reviews.apache.org/r/52010/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message