mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 52007: Added nested container helper 'parseSandboxPath()'.
Date Wed, 28 Sep 2016 05:51:06 GMT


> On Sept. 18, 2016, 2:36 p.m., Jie Yu wrote:
> > src/slave/paths.cpp, lines 106-122
> > <https://reviews.apache.org/r/52007/diff/1/?file=1501155#file1501155line106>
> >
> >     Do you also want to update the comments about the layout in paths.hpp?

Will update the comments in paths.hpp later.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52007/#review149387
-----------------------------------------------------------


On Sept. 27, 2016, 10:49 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52007/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2016, 10:49 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph Wu, Kevin
Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-6191
>     https://issues.apache.org/jira/browse/MESOS-6191
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added nested container helper 'parseSandboxPath()'.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/paths.hpp 8d8bcb41f1e63613bc09fa06e3378ec4e930878e 
>   src/slave/containerizer/mesos/paths.cpp 7635228d59a783ece0501710ec4d1f9e67252d32 
>   src/tests/paths_tests.cpp 0671ee25b484cacf08c9a20ee6eba88e6f14fa97 
> 
> Diff: https://reviews.apache.org/r/52007/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message