mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 51621: WIP: Made recovered resource allocated as soon as possible.
Date Wed, 28 Sep 2016 03:38:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51621/
-----------------------------------------------------------

(Updated 九月 28, 2016, 3:38 a.m.)


Review request for mesos, Benjamin Mahler, Jacob Janco, and Jiang Yan Xu.


Bugs: MESOS-3078
    https://issues.apache.org/jira/browse/MESOS-3078


Repository: mesos


Description
-------

Please do not review for now as it is WIP.

Enable the `recoverResources` logic to call `ensureAllocation`,
this can make sure the `allocationCandidates` can be updated
as soon as possible and allocate the resources as soon as possible
if there are no request in the message queue.


Diffs (updated)
-----

  include/mesos/allocator/allocator.hpp 486b8adc62afaad4c0785702ba43da1f9b655510 
  src/master/allocator/mesos/allocator.hpp 61159a91700270b1aa6fb335b8a41592e03ef8a9 
  src/master/allocator/mesos/hierarchical.hpp 2c31471ee0f5d6836393bf87ff9ecfd8df835013 
  src/master/allocator/mesos/hierarchical.cpp 3f51f4194c1ba7c1e4f08c3dd623281ca5754d39 
  src/master/master.cpp 66a672f6d16233e96b29e330a9e6c474546fa851 
  src/tests/allocator.hpp bce11904f0b8de66a6620b636321568fdc0d113f 
  src/tests/hierarchical_allocator_tests.cpp 46553f6d501deb37862dd5ba48be1c114f6e6cb8 
  src/tests/master_allocator_tests.cpp b4ecd461d522503264ad2e25b2bf0cfc4a0ba12a 
  src/tests/persistent_volume_tests.cpp 2ab44d11d159162dfcac9d0791b651ed059b8164 
  src/tests/reservation_endpoints_tests.cpp 7d271085d822e85d27cea5361bfee0d0d91a5691 
  src/tests/reservation_tests.cpp 6c28ab4557f342134efce0ad7cb174a5adb4dc10 
  src/tests/slave_recovery_tests.cpp 115fe942e1d5f50237c104d5bf867720ec2c2b91 
  src/tests/slave_tests.cpp 3471314675a11f850aaaa371e47b648bb43ee27e 

Diff: https://reviews.apache.org/r/51621/diff/


Testing
-------

make
make check

```
GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*PersistentVolumeTest.BadACL*/*" --verbose --gtest_repeat=20
GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*PersistentVolumeTest.GoodACL*/*" --verbose
--gtest_repeat=20
GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="ReservationEndpointsTest.UnreserveAvailableAndOfferedResources"
 --gtest_repeat=20
GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="ReservationEndpointsTest.ReserveAvailableAndOfferedResources"
 --gtest_repeat=20
GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="ReservationTest.ACLMultipleOperations" --verbose
 --gtest_repeat=20
GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterAllocatorTest/1.RebalancedForUpdatedWeights"
--gtest_repeat=30
GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.UpdateWeight" --verbose
--gtest_repeat=20
GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterAllocatorTest/*.SlaveLost" --gtest_repeat=20
GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="SlaveTest.ExecutorShutdownGracePeriod" --gtest_repeat=20
```


Thanks,

Guangya Liu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message