mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 52321: Fixed composing containerizer to handled nested containers.
Date Tue, 27 Sep 2016 23:07:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52321/#review150643
-----------------------------------------------------------


Fix it, then Ship it!




+1 on Gilbert's nit.


src/slave/containerizer/composing.cpp (line 461)
<https://reviews.apache.org/r/52321/#comment218676>

    Preferred:
    ```
    containers_.at(rootContainerId)
    ```


- Joseph Wu


On Sept. 27, 2016, 3:25 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52321/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2016, 3:25 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-6260
>     https://issues.apache.org/jira/browse/MESOS-6260
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made composing containerizer nesting aware so that operators
> can enable both mesos and docker containerizers on agents.
> Ofcourse docker containerizer is not nesting aware.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/composing.hpp 9be780201ec2efae02d560fa3560fe12f1d53a50 
>   src/slave/containerizer/composing.cpp 179304a9f0e1e4ef7e2946feea97c0897e24f5ab 
>   src/tests/default_executor_tests.cpp 3d6cbd92b916f38325f9f23245cc602bae4f83e3 
> 
> Diff: https://reviews.apache.org/r/52321/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message