mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 52285: Added 'volume/sandbox_path' isolator.
Date Tue, 27 Sep 2016 22:01:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52285/#review150631
-----------------------------------------------------------


Fix it, then Ship it!




LGTM!


src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp (line 172)
<https://reviews.apache.org/r/52285/#comment218656>

    We should use the same (or similarly worded) error message as earlier:
    ```
    "The 'linux' launcher and 'filesystem/linux' isolator must be "
    "enabled to change the rootfs and bind mount"
    ```


- Joseph Wu


On Sept. 27, 2016, 2:23 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52285/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2016, 2:23 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Joseph Wu.
> 
> 
> Bugs: MESOS-6258
>     https://issues.apache.org/jira/browse/MESOS-6258
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added 'volume/sandbox_path' isolator.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 981b36e55785b9de00a79693d5b25fe66fccb710 
>   src/Makefile.am 410b5f2e5bc50a5aa7856645c8cf4a3e43505a84 
>   src/slave/containerizer/mesos/containerizer.cpp ac2823f5452bb336b2f4eb96f65c484a5aa64f6d

>   src/slave/containerizer/mesos/isolators/volume/sandbox_path.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52285/diff/
> 
> 
> Testing
> -------
> 
> To be added. Wait for the nested container support.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message