mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 52006: Supported docker/volume isolator to be nested aware.
Date Tue, 27 Sep 2016 21:34:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52006/#review150629
-----------------------------------------------------------



Also want to confirm one thing: We cannot make sure if all of the child containers will share
the volume when using docker volume isolator, so here we will continue to generate the mount
point for each child container when prepare, right? There maybe cases some child containers
want to share volume while some do not.


src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 159 - 161)
<https://reviews.apache.org/r/52006/#comment218654>

    Just a question here: Why want to recover the orphan containers? Does the comments need
some update? It is still mentioning that the `orphan containers will be destroyed by the containerizer
through the regular cleanup path.`


- Guangya Liu


On 九月 27, 2016, 12:13 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52006/
> -----------------------------------------------------------
> 
> (Updated 九月 27, 2016, 12:13 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph Wu, Kevin
Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-6193
>     https://issues.apache.org/jira/browse/MESOS-6193
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported docker/volume isolator to be nested aware.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 2cc8e764ff18c95c29598df75cdb370ccf120662

>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp af9f3736b487b595e8768e56ce60dc4823db28a1

> 
> Diff: https://reviews.apache.org/r/52006/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message