mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sivaram Kannan <sivara...@gmail.com>
Subject Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.
Date Tue, 27 Sep 2016 19:59:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52310/
-----------------------------------------------------------

(Updated Sept. 27, 2016, 7:59 p.m.)


Review request for mesos and Joseph Wu.


Bugs: MESOS-5856
    https://issues.apache.org/jira/browse/MESOS-5856


Repository: mesos


Description (updated)
-------

Switch the uid of the binary if a user is passed from the lib_logrotate. 

Note: Previuos rbr to this commit has been discarded. Refer: https://reviews.apache.org/r/52097/


Diffs
-----

  src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 

Diff: https://reviews.apache.org/r/52310/diff/


Testing
-------

1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are
getting rotated. 
2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated.


Thanks,

Sivaram Kannan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message