mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Review Request 52305: Removed `CHECK` for no-existent resolv.conf for root containers.
Date Tue, 27 Sep 2016 17:58:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52305/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Bugs: MESOS-6259
    https://issues.apache.org/jira/browse/MESOS-6259


Repository: mesos


Description
-------

Removed `CHECK` for no-existent resolv.conf for root containers.


Diffs
-----

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 80ce25f5383476500f447570916d1907163ec896


Diff: https://reviews.apache.org/r/52305/diff/


Testing
-------

Tested with the following pod definition against `mesos-execute:
{
  "tasks":[
    {
      "name" : "server1",
      "task_id" : {"value":"server1"},
      "agent_id": {"value" : ""},
      "resources": [{
        "name": "cpus",
        "type": "SCALAR",
        "scalar": {
          "value": 0.1
        },
        "role": "*"
      },
      {
        "name": "mem",
        "type": "SCALAR",
        "scalar": {
          "value": 128
        },
        "role": "*"
      }],
      "command" : {
        "value" : "python3 -m http.server 9000"
      }
    },
    {
      "name" : "server2",
      "task_id" : {"value":"server2"},
      "agent_id": {"value" : ""},
      "resources": [{
        "name": "cpus",
        "type": "SCALAR",
        "scalar": {
          "value": 0.1
        },
        "role": "*"
      },
      {
        "name": "mem",
        "type": "SCALAR",
        "scalar": {
          "value": 128
        },
        "role": "*"
      }],
      "command" : {
        "value" : "python3 -m http.server 10000"
      }
    }
  ]
}


Thanks,

Avinash sridharan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message