mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Hindman <b...@berkeley.edu>
Subject Re: Review Request 52245: Added WEXITSTATUS and WTERMSIG gtest helpers in stout.
Date Tue, 27 Sep 2016 05:38:15 GMT


> On Sept. 25, 2016, 8:48 p.m., Jie Yu wrote:
> > 3rdparty/stout/include/stout/gtest.hpp, line 189
> > <https://reviews.apache.org/r/52245/diff/1/?file=1509782#file1509782line189>
> >
> >     Not sure if `strsignal` works fine on windows or not. @joseph, can you verify
that?

It's hard to tell from Googling. Let's see how the Windows build does. We really should hook
up the Windows builds for reviews!


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52245/#review150353
-----------------------------------------------------------


On Sept. 25, 2016, 4:10 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52245/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2016, 4:10 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added WEXITSTATUS and WTERMSIG gtest helpers in stout.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/gtest.hpp 8881159c89b97e1f528eaa27cac52051404be3c6 
>   3rdparty/stout/tests/os_tests.cpp c2900b8bf25b06a498c32c81bd2f8c852eb682f5 
> 
> Diff: https://reviews.apache.org/r/52245/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message