mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 52165: Fixed default executor tests.
Date Mon, 26 Sep 2016 23:28:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52165/
-----------------------------------------------------------

(Updated Sept. 26, 2016, 11:28 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Make review bot run again.


Bugs: MESOS-6227
    https://issues.apache.org/jira/browse/MESOS-6227


Repository: mesos


Description
-------

This change modifies a couple of default executor tests that
would fail otherwise after the launch/wait/destroy child
container changes. The changes are as under:
- Disable AuthN on the agent allowing the executor to connect.
- Fix an incorrect assumption in a test that status updates for
  different tasks would be sent in order.

Disabled the tests for now to make ReviewBot happy.
Eventually, when the launcher changes land and we are able to
launch child containers these tests would pass!


Diffs (updated)
-----

  src/tests/default_executor_tests.cpp 786fbe3baac3c1542b318a26363213a4a1945ddd 

Diff: https://reviews.apache.org/r/52165/diff/


Testing
-------

make check (on Gilbert's branch that has the launcher changes)


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message