mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 52208: Fixed warnings in health_checker.cpp.
Date Mon, 26 Sep 2016 22:57:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52208/#review150478
-----------------------------------------------------------


Fix it, then Ship it!




I can tweak this before committing.


src/health-check/health_checker.cpp (lines 185 - 187)
<https://reviews.apache.org/r/52208/#comment218462>

    The indented lines here should be aligned with the end of `delay(`.



src/health-check/health_checker.cpp (lines 592 - 594)
<https://reviews.apache.org/r/52208/#comment218463>

    Ditto here.


- Joseph Wu


On Sept. 22, 2016, 9:50 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52208/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2016, 9:50 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed warnings in health_checker.cpp.
> 
> 
> Diffs
> -----
> 
>   src/health-check/health_checker.cpp 758cbb382b08743f518022ba66eaafbea7615592 
> 
> Diff: https://reviews.apache.org/r/52208/diff/
> 
> 
> Testing
> -------
> 
> Windows: buils
> OSX: make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message