mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 52206: Fixed warnings in os.hpp.
Date Mon, 26 Sep 2016 22:39:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52206/#review150476
-----------------------------------------------------------


Fix it, then Ship it!




I can tweak these before committing.


3rdparty/stout/include/stout/windows/os.hpp (line 154)
<https://reviews.apache.org/r/52206/#comment218461>

    `CHECK_LE`.



3rdparty/stout/include/stout/windows/os.hpp (lines 156 - 158)
<https://reviews.apache.org/r/52206/#comment218460>

    `processes.data()` should go on the next line, with 4 spaces of indent.


- Joseph Wu


On Sept. 22, 2016, 9:52 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52206/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2016, 9:52 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed warnings in os.hpp.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/windows/os.hpp fb341348d842513f7479a9f00880c8b63dd49fb6

> 
> Diff: https://reviews.apache.org/r/52206/diff/
> 
> 
> Testing
> -------
> 
> Windows: build
> OSX: make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message