mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 52148: Added support for killing child containers to the default executor.
Date Mon, 26 Sep 2016 22:33:49 GMT


> On Sept. 26, 2016, 4:45 p.m., Vinod Kone wrote:
> > src/launcher/default_executor.cpp, line 389
> > <https://reviews.apache.org/r/52148/diff/3-5/?file=1508989#file1508989line389>
> >
> >     sorry, missed it earlier; why should shutdown be ignored if no task group is
launched?
> >     
> >     looks this should just call `__shutdown()` after setting `shuttingDown = true`?

Good catch. I had blatantly copied this over from the command executor. Looks like we need
to fix it there too!


> On Sept. 26, 2016, 4:45 p.m., Vinod Kone wrote:
> > src/launcher/default_executor.cpp, line 424
> > <https://reviews.apache.org/r/52148/diff/3-5/?file=1508989#file1508989line424>
> >
> >     // NOTE: We capture `connection` ...
> >     
> >     That said I don't follow why `connection` will get disconnected if we don't
capture it? Do you mean because it goes out of scope? AFAICT, it is used by `kill` calls which
makes post requests.

`Connection` follows the RAII idiom and disconnects itself when its last ref counted instance
is gone. We need to keep a reference to it to avoid disconnection and not able to send the
inflight pipelined `POST` requests.


> On Sept. 26, 2016, 4:45 p.m., Vinod Kone wrote:
> > src/launcher/default_executor.cpp, line 497
> > <https://reviews.apache.org/r/52148/diff/3-5/?file=1508989#file1508989line497>
> >
> >     LOG(WARNING).
> >     
> >     Remember that this is an executor implementation and not a library. So you can
be generous with using `LOG`.

I don't think using `VLOG()` has anything to do with it being an implementation or a library.
However, I understand that this is what we have been following in Mesos in practice and would
be good to be consistent. I removed all the occurences minus the `connectionId` mismatch logging
from `VLOG()`.


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52148/#review150411
-----------------------------------------------------------


On Sept. 25, 2016, 10:05 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52148/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2016, 10:05 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6227
>     https://issues.apache.org/jira/browse/MESOS-6227
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change implements support for killing child containers via
> the `KILL_NESTED_CONTAINER` call on the Agent API. This is
> triggered when the executor receives a `KILL`/`SHUTDOWN`
> event. Currently, only SIGKILL is supported. Also, the specifying
> custom kill policies is not yet supported.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp 2102fe8d70f0960fed669e1c4f0d6b6cd4af261c 
> 
> Diff: https://reviews.apache.org/r/52148/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message