mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 52202: Fixed warnings in encoder&decoder.hpp.
Date Mon, 26 Sep 2016 22:25:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52202/#review150471
-----------------------------------------------------------


Fix it, then Ship it!




I can tweak this before committing.


3rdparty/libprocess/src/decoder.hpp (line 242)
<https://reviews.apache.org/r/52202/#comment218457>

    `CHECK_LE`



3rdparty/libprocess/src/decoder.hpp (line 434)
<https://reviews.apache.org/r/52202/#comment218458>

    `CHECK_LE`.


- Joseph Wu


On Sept. 22, 2016, 9:55 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52202/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2016, 9:55 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed warnings in encoder&decoder.hpp.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/decoder.hpp ccf12ac8ae05141b4324ef2b4599a6bd7461c4ec 
>   3rdparty/libprocess/src/encoder.hpp af083d196aa67d08f1b3299b0a15fbc7d1fd7cd5 
> 
> Diff: https://reviews.apache.org/r/52202/diff/
> 
> 
> Testing
> -------
> 
> Windows: build
> OSX: make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message