mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Pravat <dpra...@outlook.com>
Subject Re: Review Request 52196: Fixed warnings in `read/write` functions.
Date Mon, 26 Sep 2016 21:00:44 GMT


> On Sept. 26, 2016, 8:38 p.m., Joseph Wu wrote:
> > 3rdparty/stout/include/stout/os/windows/sendfile.hpp, line 31
> > <https://reviews.apache.org/r/52196/diff/1/?file=1509014#file1509014line31>
> >
> >     What's this used for?  Is MSVC warning because of the bit shifting (`offset
>> 32`) below?

Yes.


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52196/#review150439
-----------------------------------------------------------


On Sept. 23, 2016, 5:05 a.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52196/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2016, 5:05 a.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed warnings in `read/write` functions.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/windows/read.hpp cb0abf70307f0dbba0b8f68e884df199b0359186

>   3rdparty/stout/include/stout/os/windows/sendfile.hpp 4c5178e1f3696906aa1cf93b8ca450f61ba79355

>   3rdparty/stout/include/stout/os/windows/write.hpp 705ad03ee58f9cc822ec1ed25fd10f39059717d4

> 
> Diff: https://reviews.apache.org/r/52196/diff/
> 
> 
> Testing
> -------
> 
> OSX: make check
> Windows: build
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message