mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 52194: Added `socket` functions to translate parameters.
Date Mon, 26 Sep 2016 20:55:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52194/#review150438
-----------------------------------------------------------


Fix it, then Ship it!




I can tweak these before committing.


3rdparty/stout/include/stout/os/posix/socket.hpp (line 23)
<https://reviews.apache.org/r/52194/#comment218426>

    s/os/net/



3rdparty/stout/include/stout/os/windows/socket.hpp (line 143)
<https://reviews.apache.org/r/52194/#comment218431>

    I would add a quick note about these wrappers:
    ```
    NOTE: The below wrappers are used to silence some implicit type casting warnings.
    ```



3rdparty/stout/include/stout/os/windows/socket.hpp (line 145)
<https://reviews.apache.org/r/52194/#comment218424>

    You can use `CHECK_LE(addrlen, INT32_MAX);` instead.
    
    Ditto below.


- Joseph Wu


On Sept. 22, 2016, 10:04 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52194/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2016, 10:04 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `socket` functions to translate parameters.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/posix/socket.hpp ab5f62a67c3adfe4d0c4c3532f9c2b4d43336c48

>   3rdparty/stout/include/stout/os/windows/socket.hpp d564a2bcc78570beb76a71cf35f3902333cd99ea

> 
> Diff: https://reviews.apache.org/r/52194/diff/
> 
> 
> Testing
> -------
> 
> Windows: build
> OSX: make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message