mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 52235: Supported mesos containerizer recover to be nested aware.
Date Mon, 26 Sep 2016 17:46:55 GMT


> On Sept. 25, 2016, 7:27 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, lines 800-812
> > <https://reviews.apache.org/r/52235/diff/1/?file=1509681#file1509681line800>
> >
> >     Why having a separate look for extras? Can you just inline into the first loop?
Let's keep creating of `Container` and insert into its parent close together.
> 
> Gilbert Song wrote:
>     I did it on purpose, since it may be possible that the extra list from the `launcher->recover()`
container parent-child relationship. However, that is a hashset. We cannot guarantee when
we are adding the `containerId` to its parent children list, the parentContainerId exists
in `containers_` already.

hum, ic. In that sense, i'd actually prefer adding the parent child relationship in the end
of recover.

In other words, we don't set container->children until the end. In the end, we just scan
`containers_` and construct the parent/child relationship.

In that way, we no longer has that limitation for getContainerIds to return pre-order walk
result.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52235/#review150344
-----------------------------------------------------------


On Sept. 24, 2016, 6:50 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52235/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2016, 6:50 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph Wu, Kevin
Klues, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported mesos containerizer recover to be nested aware.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.hpp 16f9e3e92e90fe7f8a0ebd24e567800e1f285bc9

>   src/slave/containerizer/mesos/containerizer.cpp 144b0db501d40d4e0bba12672723616bedd76e7e

> 
> Diff: https://reviews.apache.org/r/52235/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message