mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 52256: Made `FlagsBase::extract` publicly accessible.
Date Mon, 26 Sep 2016 16:16:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52256/
-----------------------------------------------------------

Review request for mesos and Till Toenshoff.


Bugs: MESOS-6216
    https://issues.apache.org/jira/browse/MESOS-6216


Repository: mesos


Description
-------

This function contains important business logic on how environment
variables are interpreted (keys are largely case-insensitive, and
duplicates are dropped in a certain order). Make this function
`public` so users interested in seeing what environment variables
`Flags` would see are not tempted to reimplement it (likely
incompletely or incorrectly).


Diffs
-----

  3rdparty/stout/include/stout/flags/flags.hpp 4ca6c69aeb1e3343e9b0ae2562c450c4c645890c 

Diff: https://reviews.apache.org/r/52256/diff/


Testing
-------

Tested on various platforms in internal CI as part of https://reviews.apache.org/r/52154/.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message