mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 52154: Avoided modifying process environment.
Date Mon, 26 Sep 2016 16:16:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52154/
-----------------------------------------------------------

(Updated Sept. 26, 2016, 6:16 p.m.)


Review request for mesos, Joris Van Remoortere and Till Toenshoff.


Changes
-------

Fixed to correctly reproduce overriding behavior of old implementation when variables with
different case were found, e.g., `SSL_foo` and `LIBPROCESS_SSL_Foo` would attempt to update
the same variable `foo` and should contain compatible values, or `SSL_foo` would likely be
overriden by `SSL_Foo` (at least in the `C` locale), which would e.g., need to be compatible
with `LIBPROCESS_SSL_FOO`.


Bugs: MESOS-6216
    https://issues.apache.org/jira/browse/MESOS-6216


Repository: mesos


Description
-------

This code modified the process environment in order to support upgrading
on the fly from old-style libprocess SSL variables `SSL_` to
`LIBPROCESS_SSL_`. Modifying the process environment at this point is
not safe as other actors might concurrently read out that same
environment.

Instead avoid changing the process environment altogether since flags
can just as well be read from a map.


Diffs (updated)
-----

  3rdparty/libprocess/src/openssl.cpp c09cdc89509e4e4ca4c8a0f4fb0a57156a3a6091 

Diff: https://reviews.apache.org/r/52154/diff/


Testing
-------

Tested on various platforms in internal CI.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message