mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 52147: Added support for launching child containers to the default executor.
Date Mon, 26 Sep 2016 15:56:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52147/#review150407
-----------------------------------------------------------


Fix it, then Ship it!





src/launcher/default_executor.cpp (line 241)
<https://reviews.apache.org/r/52147/#comment218380>

    I would change these to LOG(ERROR) because dropping a task group launch is an important
enough event that we want to surface without expecting users to set GLOG_v.
    
    here and everywhere else.


- Vinod Kone


On Sept. 25, 2016, 9:36 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52147/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2016, 9:36 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6227
>     https://issues.apache.org/jira/browse/MESOS-6227
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds support for sending the `LAUNCH_NESTED_CONTAINER`
> call to the agent to launch a child container.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp 2102fe8d70f0960fed669e1c4f0d6b6cd4af261c 
> 
> Diff: https://reviews.apache.org/r/52147/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message