mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 52234: Added containerizer helper method 'getContainerIds()'.
Date Mon, 26 Sep 2016 05:11:34 GMT


> On Sept. 25, 2016, 11:10 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/paths.cpp, lines 156-169
> > <https://reviews.apache.org/r/52234/diff/1/?file=1509679#file1509679line156>
> >
> >     The logic here is a little hard to follow. I am wondering if we should let the
recursive helper takes the following parameter:
> >     ```
> >     // Returns all the container IDs under the
> >     // given parent container, in pre-order.
> >     Try<vector<ContainerID>> helper(
> >         const ContainerID& parentContainerId)
> >     ```
> >     
> >     You can use `getRuntimePath` to get the parent container runtime path first,
do an `ls`, and construct the child container ID, then recursively dive into the even nested
container.

Thanks, it does look cleaner.

Note: I decide to go with `Option<ContainerID>` for the helper parameter.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52234/#review150342
-----------------------------------------------------------


On Sept. 24, 2016, 11:50 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52234/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2016, 11:50 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph Wu, Kevin
Klues, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is a helper function to collect all containerIds (include top
> level and nested) from the runtime directory.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/paths.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/paths.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52234/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message