mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <>
Subject Re: Review Request 52231: Fixed driver based schedulers to ACK updates from HTTP executors.
Date Sun, 25 Sep 2016 22:08:19 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 25, 2016, 10:08 p.m.)

Review request for mesos and Benjamin Mahler.


Review Comments, NNFR.

Bugs: MESOS-6245

Repository: mesos


Previously, driver based schedulers were not able to acknowledge
status updates from HTTP based executors if they had explicit
acknowledgements enabled. This was due to the fact that we
were not populating `TaskStatus.slave_id` correctly if not
set. It would also be great to validate `TaskStatus.slave_id`
set by the executor and let them know if the value is incorrect.

Diffs (updated)

  src/common/protobuf_utils.cpp 5db4be4bdc7b9a3a2a66a17f8a9ac74c8d3dfbf6 
  src/slave/slave.cpp 11e9c8af87aa5153f72f2a20cc578fe3d729b153 
  src/tests/command_executor_tests.cpp beb3cbcfbd65bc63b7a97f704775b46f691ba600 



make check


Anand Mazumdar

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message