mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 52149: Added support for waiting on child containers to the default executor.
Date Sun, 25 Sep 2016 22:05:41 GMT


> On Sept. 24, 2016, 9:57 p.m., Vinod Kone wrote:
> > src/launcher/default_executor.cpp, lines 797-803
> > <https://reviews.apache.org/r/52149/diff/3/?file=1508990#file1508990line797>
> >
> >     Would be great if these can be merged into one struct `Container`
> >     
> >     struct Container
> >     {
> >       ContainerID containerId;
> >       TaskID taskId;
> >       Option<Connection> waiting;
> >     }

I left a `TODO` to address this.


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52149/#review150318
-----------------------------------------------------------


On Sept. 23, 2016, 3:28 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52149/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2016, 3:28 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6227
>     https://issues.apache.org/jira/browse/MESOS-6227
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds support for waiting on child containers via the
> `WAIT_NESTED_CONTAINER` call on the Agent API. If the connection
> fails due to a temporary network blip, it reconnects with the
> agent.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp 2102fe8d70f0960fed669e1c4f0d6b6cd4af261c 
> 
> Diff: https://reviews.apache.org/r/52149/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message