mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 52149: Added support for waiting on child containers to the default executor.
Date Sun, 25 Sep 2016 22:05:39 GMT


> On Sept. 24, 2016, 9:53 p.m., Vinod Kone wrote:
> > src/launcher/default_executor.cpp, line 427
> > <https://reviews.apache.org/r/52149/diff/3/?file=1508990#file1508990line427>
> >
> >     just inline this function.

This is invoked by the `retry()` handler too asynchronously. Hence, it can't be inlined.


> On Sept. 24, 2016, 9:53 p.m., Vinod Kone wrote:
> > src/launcher/default_executor.cpp, line 132
> > <https://reviews.apache.org/r/52149/diff/3/?file=1508990#file1508990line132>
> >
> >     don't you want to check `if (!killed)`?

hmm, take this scenario:

- We had sent `KILL_NESTED_CONTAINER` call(s) for killing child containers. While we were
waiting on those containers to terminate, we got disconnected from the agent.
- We ignored all `waited()` callbacks thereafter owing to being disconnected.
- When the agent process was up again and after the executor subscribed again with the agent,
we still want to `wait()` on the child containers to correctly forward the TASK_KILLED status
updates to the scheduler. If we have the boolean `killed` check, we won't be able to `wait()`
on the child containers any more.


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52149/#review150316
-----------------------------------------------------------


On Sept. 23, 2016, 3:28 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52149/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2016, 3:28 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6227
>     https://issues.apache.org/jira/browse/MESOS-6227
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds support for waiting on child containers via the
> `WAIT_NESTED_CONTAINER` call on the Agent API. If the connection
> fails due to a temporary network blip, it reconnects with the
> agent.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp 2102fe8d70f0960fed669e1c4f0d6b6cd4af261c 
> 
> Diff: https://reviews.apache.org/r/52149/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message