mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 52245: Added WEXITSTATUS and WTERMSIG gtest helpers in stout.
Date Sun, 25 Sep 2016 20:48:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52245/#review150353
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/stout/include/stout/gtest.hpp (line 189)
<https://reviews.apache.org/r/52245/#comment218309>

    Not sure if `strsignal` works fine on windows or not. @joseph, can you verify that?



3rdparty/stout/include/stout/gtest.hpp (line 304)
<https://reviews.apache.org/r/52245/#comment218311>

    `s/_FOR//`?



3rdparty/stout/include/stout/gtest.hpp (line 322)
<https://reviews.apache.org/r/52245/#comment218312>

    strsignal?



3rdparty/stout/include/stout/gtest.hpp (line 324)
<https://reviews.apache.org/r/52245/#comment218314>

    strsignal?



3rdparty/stout/include/stout/gtest.hpp (line 354)
<https://reviews.apache.org/r/52245/#comment218313>

    strsignal?



3rdparty/stout/include/stout/gtest.hpp (line 356)
<https://reviews.apache.org/r/52245/#comment218315>

    strsignal?



3rdparty/stout/include/stout/gtest.hpp (line 368)
<https://reviews.apache.org/r/52245/#comment218308>

    Miss 'W'?
    
    `EXPECT_WTERMSIG_NE`


- Jie Yu


On Sept. 25, 2016, 4:10 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52245/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2016, 4:10 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added WEXITSTATUS and WTERMSIG gtest helpers in stout.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/gtest.hpp 8881159c89b97e1f528eaa27cac52051404be3c6 
>   3rdparty/stout/tests/os_tests.cpp c2900b8bf25b06a498c32c81bd2f8c852eb682f5 
> 
> Diff: https://reviews.apache.org/r/52245/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message