mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 52240: Fixed unit test 'ROOT_RecoverOrphanedPersistentVolume'.
Date Sun, 25 Sep 2016 20:08:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52240/#review150352
-----------------------------------------------------------




src/tests/containerizer/filesystem_isolator_tests.cpp 
<https://reviews.apache.org/r/52240/#comment218307>

    Hum, why this is redundent. How do you make sure all orphans cleanups are done?


- Jie Yu


On Sept. 24, 2016, 6:50 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52240/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2016, 6:50 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph Wu, Kevin
Klues, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch removed the redundant '___recover()' call in the unit test.
> Also this '___recover()' method will be removed in the next path when
> we re-write the containerizer::recover() logic for nested containers
> support.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 680d68b7490ccc145f26037c96d4e23bd74a6f58

> 
> Diff: https://reviews.apache.org/r/52240/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message