mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 52008: Added slave helper function for nested containers 'getSandboxPath()'.
Date Sun, 25 Sep 2016 19:57:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52008/#review150351
-----------------------------------------------------------




src/slave/paths.hpp (line 201)
<https://reviews.apache.org/r/52008/#comment218306>

    Based on our conversation last time, please move this helper to containerizer/mesos/paths.hpp|cpp.
    
    We probably should just have `getSandboxPath` for nested containers. For top level container,
still use the getExecutorRunPath.


- Jie Yu


On Sept. 25, 2016, 6:11 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52008/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2016, 6:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph Wu, Kevin
Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-6191
>     https://issues.apache.org/jira/browse/MESOS-6191
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added slave helper function for nested containers 'getSandboxPath()'.
> 
> 
> Diffs
> -----
> 
>   src/slave/paths.hpp ebff3a9fab3f4a8d38502fe02bd5a34cf95c1830 
>   src/slave/paths.cpp eb414caae5847949854743d4e3c603217a897898 
> 
> Diff: https://reviews.apache.org/r/52008/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message