mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Will Rouesnel <w.roues...@gmail.com>
Subject Re: Review Request 51257: Add external process container logger.
Date Sun, 25 Sep 2016 18:11:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51257/
-----------------------------------------------------------

(Updated Sept. 25, 2016, 6:11 p.m.)


Review request for mesos and Joseph Wu.


Changes
-------

Make external_logger_cmd a required argument.


Bugs: MESOS-6003
    https://issues.apache.org/jira/browse/MESOS-6003


Repository: mesos


Description
-------

Adds the external process container logger. This functions like the
logrotate container logger, but instead calls a custom host binary
(or script) and passes the executorInfo as JSON via environment
variables. This makes it very easy for users to configure custom
logging solutions, without needing to write and maintain logging
modules.

Tests passing and complete.


Diffs (updated)
-----

  src/Makefile.am 410b5f2e5bc50a5aa7856645c8cf4a3e43505a84 
  src/slave/container_loggers/lib_externallogger.hpp PRE-CREATION 
  src/slave/container_loggers/lib_externallogger.cpp PRE-CREATION 
  src/tests/container_logger_external.sh PRE-CREATION 
  src/tests/container_logger_tests.cpp f76117230e0517ddc3cb8e0bf482085fad6950d2 
  src/tests/module.hpp e661d95fa44fc1aedfe83c564c826d5b7d32c85b 
  src/tests/module.cpp 5b83fd6358ddea4c9d849b8992e1a6040ef74505 

Diff: https://reviews.apache.org/r/51257/diff/


Testing
-------

Adds ContainerLoggerTest.EXTERNAL_RecieveEnvironment which tests all major parameters of the
change.

A synthetic external container logger is provided by the script tests/container_logger_external.sh
which is setup to fail if any important output is unavailable to the logging process. 

The other basic checks are duplicated from the Logrotate container logger, from where this
change inherits a lot of its code.


Thanks,

Will Rouesnel


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message