mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 51672: Changed containerizer launch for nested containers to return a bool.
Date Sun, 25 Sep 2016 17:14:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51672/
-----------------------------------------------------------

(Updated Sept. 25, 2016, 10:14 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph Wu, and Kevin
Klues.


Repository: mesos


Description
-------

Because the containerizer launch for nested containers shares logic
with the top level container launch. We should return a boolean
consistently.


Diffs
-----

  src/slave/containerizer/containerizer.hpp f13669d0dfc4ce3287cfe630cabd0470dc765b51 
  src/slave/containerizer/mesos/containerizer.hpp 078ef4f4e7bf5e1522804a720c51cfa5518d8efd

  src/slave/containerizer/mesos/containerizer.cpp 1a120f191e4ff0e2b31dd0a9a6bced784a56612c


Diff: https://reviews.apache.org/r/51672/diff/


Testing
-------

make check


Thanks,

Gilbert Song


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message