mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 51670: Changed the containerizer launch interface for nested containers.
Date Sun, 25 Sep 2016 17:12:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51670/#review150337
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/containerizer.cpp (line 1477)
<https://reviews.apache.org/r/51670/#comment218272>

    Let's do that in the other `launch` where you construct `Container` struct so that it
is done in an atomic step (instead of spanning multiple callbacks).



src/slave/http.cpp (lines 1929 - 1930)
<https://reviews.apache.org/r/51670/#comment218271>

    use os::temp() here.


- Jie Yu


On Sept. 24, 2016, 6:50 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51670/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2016, 6:50 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph Wu, and
Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The containerizer launch for nested containers needs to share logic
> with the top level container launch. Necessary information (e.g.,
> user, directory etc.) need to be included.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/containerizer.hpp 47a8582f37c0fc9fb0d8cb8a0b979802f603b25f

>   src/slave/containerizer/mesos/containerizer.hpp 16f9e3e92e90fe7f8a0ebd24e567800e1f285bc9

>   src/slave/containerizer/mesos/containerizer.cpp 144b0db501d40d4e0bba12672723616bedd76e7e

>   src/slave/http.cpp 349d307284809353d950c6f281aa8605eb9289e9 
>   src/tests/api_tests.cpp e857b17cfe5f05d59859263c025564d33700a26c 
>   src/tests/containerizer/mock_containerizer.hpp 840c51148399d2d2ebfb59106c1732ed5e91e61e

> 
> Diff: https://reviews.apache.org/r/51670/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message