mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 51669: Changed ContainerConfig::ExecutorInfo from required to optional.
Date Sun, 25 Sep 2016 17:06:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51669/#review150336
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Sept. 24, 2016, 6:50 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51669/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2016, 6:50 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph Wu, and
Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> For nested container launch in containerizer, a new launch method
> was introduced for nested container only. However, 'ExecutorInfo'
> is not included in this new launch method, only 'CommandInfo'
> instead. To construct the 'ContainerConfig' for nested container
> launch, we need to update the 'ExecutorInfo' in 'ContainerConfig'
> from required to optional.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/containerizer.proto 20db010ea158a813034b411111ce9cddac7d8317 
> 
> Diff: https://reviews.apache.org/r/51669/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message