mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 52148: Added support for killing child containers to the default executor.
Date Sat, 24 Sep 2016 21:40:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52148/#review150315
-----------------------------------------------------------




src/launcher/default_executor.cpp (line 368)
<https://reviews.apache.org/r/52148/#comment218244>

    log a statement.



src/launcher/default_executor.cpp (line 376)
<https://reviews.apache.org/r/52148/#comment218245>

    log a statement.



src/launcher/default_executor.cpp (line 429)
<https://reviews.apache.org/r/52148/#comment218246>

    log a message here.



src/launcher/default_executor.cpp (lines 438 - 444)
<https://reviews.apache.org/r/52148/#comment218247>

    Looks like this cannot happen because it is synchronously called from `_shutdown` ?



src/launcher/default_executor.cpp (lines 449 - 455)
<https://reviews.apache.org/r/52148/#comment218248>

    How is this possible given that this function is synchronously called from `_shutdown`?



src/launcher/default_executor.cpp (line 492)
<https://reviews.apache.org/r/52148/#comment218249>

    why VLOG instead of LOG(ERROR)?


- Vinod Kone


On Sept. 23, 2016, 3:28 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52148/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2016, 3:28 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6227
>     https://issues.apache.org/jira/browse/MESOS-6227
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change implements support for killing child containers via
> the `KILL_NESTED_CONTAINER` call on the Agent API. This is
> triggered when the executor receives a `KILL`/`SHUTDOWN`
> event. Currently, only SIGKILL is supported. Also, the specifying
> custom kill policies is not yet supported.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp 2102fe8d70f0960fed669e1c4f0d6b6cd4af261c 
> 
> Diff: https://reviews.apache.org/r/52148/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message