mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 51407: Updated mesos containerizer to checkpoint container runtime information.
Date Sat, 24 Sep 2016 20:20:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51407/
-----------------------------------------------------------

(Updated Sept. 24, 2016, 8:20 p.m.)


Review request for mesos and Jie Yu.


Changes
-------

Updated to address Jie's comments. Biggest change was moving the creation of the `runtime_dir`
to the top of the `launch()` call before `prepare()` is called on the provisioner / isolators.
This will allow us to put an optimization in the recover path to treat any containers that
actually have this directory created for them as "known orphans". This will allow their destruction
to be deferred to the bottom of the containerizer.recover() path.


Bugs: MESOS-6204
    https://issues.apache.org/jira/browse/MESOS-6204


Repository: mesos


Description
-------

This includes checkpointing both the container pid and the status of
the container upon exit. This also includes an update to tests to
account for new 'init' process semantics in a container. That is, the
name of the init process of the container is now "mesos-containerizer"
not "sh".


Diffs (updated)
-----

  src/slave/containerizer/mesos/containerizer.hpp 16f9e3e92e90fe7f8a0ebd24e567800e1f285bc9

  src/slave/containerizer/mesos/containerizer.cpp ed3089a089128e712c4a95e7b5842e9c2abacbb5

  src/tests/containerizer/isolator_tests.cpp b4d25e57df7f0e157769c9ae4f7847657c505e78 

Diff: https://reviews.apache.org/r/51407/diff/


Testing
-------

$ GTEST_FILTER="" make -j check
$ src/mesos-tests
$ sudo src/mesos-tests


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message