mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 52192: Fixed VC warnings in bytes.hpp.
Date Sat, 24 Sep 2016 01:42:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52192/#review150283
-----------------------------------------------------------



It's a bit odd that this function signature has a double.  We should investigate why and decided
whether or not we should change the interface to `uint64_t`.

- Joseph Wu


On Sept. 22, 2016, 9:47 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52192/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2016, 9:47 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed VC warnings in bytes.hpp.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/bytes.hpp 9debe2f5579b9b2d67933ecc2bfcc40c2730f7f1 
> 
> Diff: https://reviews.apache.org/r/52192/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message