mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 52180: Added ExitedEvents for links whose sockets fail on creation.
Date Sat, 24 Sep 2016 01:04:29 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 23, 2016, 6:04 p.m.)

Review request for mesos, Benjamin Mahler, Artem Harutyunyan, and Joris Van Remoortere.


Renamed `fd_hogs` and moved that code down a bit.

Bugs: MESOS-6246

Repository: mesos


When we try to link to a remote process, we will send the linkee an
`ExitedEvent` when the link is broken or if the connection fails.
This patch adds an `ExitedEvent` when the socket creation step fails.
This is logically equivalent to having the connection step fail.

Because this is an entirely unexpected case, the log level should be
a WARNING or higher.

Diffs (updated)

  3rdparty/libprocess/src/process.cpp 02a192529e53479d5a163fa6a20873674b51ee2c 
  3rdparty/libprocess/src/tests/process_tests.cpp b9feec7e34cffe19e49035f8865b150f79258f54



make check

3rdparty/libprocess/libprocess-tests --gtest_filter="ProcessRemoteLinkTest.RemoteLinkLeak"
--gtest_repeat=5000 --gtest_break_on_failure


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message