mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 52225: Added missing WSTOPSIG macro to windows.
Date Sat, 24 Sep 2016 00:02:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52225/#review150269
-----------------------------------------------------------


Ship it!




If this breaks anything on Windows, I'll take responsibility for fixing it :)

- Joseph Wu


On Sept. 23, 2016, 1:41 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52225/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2016, 1:41 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These macros are still not "correct", in that they don't accurately
> represent the completion status of a process on windows, but they are
> now defined so we can fill them in with the proper implementations
> later.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/windows.hpp 5cca853c4b090c4516ad4ec04c6e5830a4e7ccfa 
> 
> Diff: https://reviews.apache.org/r/52225/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message