mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 52013: Added helpers for maintaining files in a container runtime directory.
Date Fri, 23 Sep 2016 23:56:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52013/#review150264
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/paths.hpp (line 17)
<https://reviews.apache.org/r/52013/#comment218153>

    `__MESOS_CONTAINERIZER_PATHS_HPP__`



src/slave/containerizer/mesos/paths.hpp (line 33)
<https://reviews.apache.org/r/52013/#comment218154>

    2 lines apart



src/slave/containerizer/mesos/paths.hpp (line 63)
<https://reviews.apache.org/r/52013/#comment218156>

    camelCase here.


- Jie Yu


On Sept. 23, 2016, 8:51 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52013/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2016, 8:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-6204
>     https://issues.apache.org/jira/browse/MESOS-6204
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added helpers for maintaining files in a container runtime directory.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 42c52b60cc850901f2eff1545cf7900f4a65ca81 
>   src/Makefile.am bfdb66a6969a35660d545210c1c6951926117ef3 
>   src/slave/containerizer/mesos/paths.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/paths.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52013/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message