mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 52222: Changed the name of a constant in the tests.
Date Fri, 23 Sep 2016 20:52:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52222/#review150233
-----------------------------------------------------------


Ship it!




Ship It!

- Michael Park


On Sept. 23, 2016, 7:31 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52222/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2016, 7:31 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This changes the `DEFAULT_ROLE` constant to
> `DEFAULT_TEST_ROLE` to avoid confusion with
> the master's `--default_role`.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp 3cd63bdf34eaad2a9c9cb897c62294c7f0c622dc 
>   src/tests/persistent_volume_tests.cpp a726d784a9e32fb81aa579d37205baed0f4734cc 
> 
> Diff: https://reviews.apache.org/r/52222/diff/
> 
> 
> Testing
> -------
> 
> `GTEST_FILTER="*PersistentVolumeTest*" bin/mesos-tests.sh`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message