mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Review Request 52224: Updated check for instantiating the "windows" launcher.
Date Fri, 23 Sep 2016 20:40:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52224/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Repository: mesos


Description
-------

Previously, we allowed the posix launcher to specified on windows and
just blindly ignored it and instantiated a windows launcher anyway.
This was likely due to legacy code, not setting the default launcher
properly in flags.cpp. Now that we set the default to "windows"
properly, this hack is no longer needed.


Diffs
-----

  src/slave/containerizer/mesos/containerizer.cpp 144b0db501d40d4e0bba12672723616bedd76e7e


Diff: https://reviews.apache.org/r/52224/diff/


Testing
-------


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message