mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 51720: Updated tests to properly set 'flags.launcher' with correct value.
Date Fri, 23 Sep 2016 20:38:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51720/
-----------------------------------------------------------

(Updated Sept. 23, 2016, 8:38 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Changes
-------

Rebased on master.


Bugs: MESOS-6141
    https://issues.apache.org/jira/browse/MESOS-6141


Repository: mesos


Description
-------

In some of our tests we manually create a 'PosixLauncher' rather than
relying on the value of 'flags.launcher' to decide which type of
launcher to create. Since calls to 'CreateSlaveFlags()' set
'flags.launcher' to 'linux' by default, there was a discrepency in
what the flags said, and what actual launcher type we were creating.

This commit fixes this to explicitly set 'flags.launcher' to the
appropriate type.


Diffs (updated)
-----

  src/tests/container_logger_tests.cpp 1b121a2fcce2d874aeefc4257b9d4e594866e78d 
  src/tests/containerizer/mesos_containerizer_tests.cpp f5cc9dbbbb52c9629eb18b8f2dd1a380996955cf


Diff: https://reviews.apache.org/r/51720/diff/


Testing
-------

$ GTEST_FILTER="" make -j check
$ src/mesos-tests
$ sudo src/mesos-tests


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message