mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mao Geng <geng...@pinterest.com>
Subject Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.
Date Fri, 23 Sep 2016 16:58:50 GMT


> On Sept. 23, 2016, 4:43 p.m., haosdent huang wrote:
> > 3rdparty/stout/tests/os_tests.cpp, lines 697-699
> > <https://reviews.apache.org/r/52048/diff/2/?file=1507948#file1507948line697>
> >
> >     How about `EXPECT_EQ(tokens.get(), expected_gids);` here?

Not sure if EXPECT_EQ can compare two vectors directly? 
I saw https://github.com/google/googletest/blob/master/googletest/docs/Primer.md has an example:
 
```
for (int i = 0; i < x.size(); ++i) {
  EXPECT_EQ(x[i], y[i]) << "Vectors x and y differ at index " << i;
}
```


- Mao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52048/#review150202
-----------------------------------------------------------


On Sept. 22, 2016, 7:29 a.m., Mao Geng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52048/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2016, 7:29 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5909
>     https://issues.apache.org/jira/browse/MESOS-5909
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed OsTest.User test failure due to gids ordering.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/tests/os_tests.cpp c2900b8 
> 
> Diff: https://reviews.apache.org/r/52048/diff/
> 
> 
> Testing
> -------
> 
> Just changed the OsTest.User test. `make check` passed on Ubuntu 12.04.5 LTS.
> 
> 
> Thanks,
> 
> Mao Geng
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message