mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.
Date Fri, 23 Sep 2016 15:06:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51803/#review150184
-----------------------------------------------------------




include/mesos/mesos.proto (line 338)
<https://reviews.apache.org/r/51803/#comment218051>

    s/"strategy"/type



include/mesos/mesos.proto (line 339)
<https://reviews.apache.org/r/51803/#comment218052>

    s/strategy/type



include/mesos/mesos.proto (lines 349 - 352)
<https://reviews.apache.org/r/51803/#comment218054>

    Let's rephrase a bit. How about
    
    ```
      // Describes an HTTP health check. Sends a GET request to
      // scheme://<host>:port/path. Note that <host> is not configurable and is
      // resolved automatically, in most cases to 127.0.0.1. Default executors
      // treat return codes between 200 and 399 as success; custom executors
      // may employ a different strategy, e.g. leveraging the `statuses` field.
    ```



include/mesos/mesos.proto (line 352)
<https://reviews.apache.org/r/51803/#comment218050>

    s/localhost/127.0.0.1



include/mesos/mesos.proto (lines 371 - 372)
<https://reviews.apache.org/r/51803/#comment218049>

    Let's follow Yan's suggestion and add something like
    
    ```
        // NOTE: It is up to the custom executor to interpret and act on this
        // field. Setting this field has no effect on the default executors.
        //
        // TODO(haosdent): Deprecate this field when we add better support for
        // success and possibly failure statuses, e.g. ranges of success and
        // failure statuses.
    ```


- Alexander Rukletsov


On Sept. 21, 2016, 6:21 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51803/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2016, 6:21 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joseph Wu, Silas Snider, and Jiang Yan
Xu.
> 
> 
> Bugs: MESOS-6110
>     https://issues.apache.org/jira/browse/MESOS-6110
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 2209ea2fb0bf39c773d60f8a0eea865320a03bb6 
>   include/mesos/v1/mesos.proto 00c623450268a990d48b4e119aa9429fabf2f135 
> 
> Diff: https://reviews.apache.org/r/51803/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message