mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 51560: Deprecated using health checks without setting the type.
Date Fri, 23 Sep 2016 14:52:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51560/#review150182
-----------------------------------------------------------




src/health-check/health_checker.cpp (line 188)
<https://reviews.apache.org/r/51560/#comment218044>

    `UNREACHABLE` does not say what the problem is. How about this:
    `LOG(FATAL) << "Invalid health check";`



src/health-check/health_checker.cpp (lines 191 - 192)
<https://reviews.apache.org/r/51560/#comment218045>

    s/. U/; u
    please move trailing space onto the next line



src/health-check/health_checker.cpp (lines 620 - 621)
<https://reviews.apache.org/r/51560/#comment218046>

    Blank comment line, please



src/tests/health_check_tests.cpp (lines 210 - 211)
<https://reviews.apache.org/r/51560/#comment218047>

    Blank comment line, please.



src/tests/health_check_tests.cpp (lines 223 - 224)
<https://reviews.apache.org/r/51560/#comment218048>

    Ditto.


- Alexander Rukletsov


On Sept. 21, 2016, 6:21 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51560/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2016, 6:21 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joseph Wu, Silas Snider, and Jiang Yan
Xu.
> 
> 
> Bugs: MESOS-6110
>     https://issues.apache.org/jira/browse/MESOS-6110
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Health checks must supply set type field from now on. Additionally,
> `HealthCheck.HTTP` message has been renamed to
> `HealthCheck.HttpCheckInfo` to avoid naming collisions.
> 
> 
> Diffs
> -----
> 
>   src/health-check/health_checker.cpp 758cbb382b08743f518022ba66eaafbea7615592 
>   src/tests/health_check_tests.cpp 30b5a2f6b256b795853553f2e5cb3c5e08512a5f 
> 
> Diff: https://reviews.apache.org/r/51560/diff/
> 
> 
> Testing
> -------
> 
> Could verfied from https://github.com/haosdent/mesos/blob/85abb6da058bf8daf4e794df7da8eb5f240b671c/docs/upgrades.md
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message